Amazon QDetector Library Sign in to Amazon Q

Amazon Q

Detector Library

Java detectors (186/186)

Reflected cross site scripting Mandatory method not called after object creation Process empty record list in Amazon KCL Amazon STS regional instead of global endpoint AWS object presence check Poor error handling java rule Incorrect type conversion or cast Missing Authentication Missing timeout check on CountDownLatch.await Unspecified default value Device Permission Usage.Check eagle handler and authn handler ordering Deserialization of untrusted object Preserve thread interruption status rule Missing check on the value returned by moveToFirst API Missing timeout check on ExecutorService.awaitTermination Overflow when deserializing relational database objects Custom manual retries of AWS SDK calls Missing null check for cache response metadata Inefficient usage of Transaction library from AWS Labs Inefficient exception handling Insecure connection using unencrypted protocol Insecure Usage Of Cache Insecure Cryptographic Cipher Use of a deprecated method Error-prone AWS IAM policy creation Use of externally-controlled input to build connection string Inefficient Amazon S3 manual pagination Mutually exclusive call Bit shift checking AWS Lambda client not reused Missing check on the result of createNewFile Sensitive data stored unencrypted due to partial encryption Application logging of sensitive object data Missing AWS_SECURITY_TOKEN Missing statement to record cause of InvocationTargetException Misconfigured Concurrency Inefficient polling of AWS resource Improper Initialization Unexpected re-assignment of synchronized objects XPath injection Transitive auth rule AWS client not reused in a Lambda function Denial of service rule HTTP Connection Not Closed Long polling is not enabled in Amazon SQS XML Validation Insecure temporary file or directory Use of low-Level functionality HTTP response splitting Input and output values become out of sync Use String To Store Aws Account Id Server-side request forgery Missing Authorization for address id Do not catch and throw exception Concurrency deadlock Check mutable property in handler class Not recommended aws credentials classes Path traversal Override of reserved variable names in a Lambda function Missing byte array length of JSON parser Insecure Trust Manager Usage of an API that is not recommended Hardcoded credentials Weak Initialization Vector (IV)Insecure JSON web token (JWT) parsing Not calling finalize causes skipped cleanup steps Unchecked S3 object metadata content length Fortify Process Control Untrusted data in security decision Permissive cors configuration rule Insecure cookie Resource leak XML External Entity AWS client credentials AWS Region Handling in Java.Allow-listing pre-production service principals to production Wrapping Caught Invocation Target Exception Bad parameters used with AWS API methods Missing position check before getting substring LDAP injection Avoid reset exception in Amazon S3 Insecure hashing Backward compatibility breaks with error message parsing Inefficient map entry iteration Missing S3 bucket owner condition AWS DynamoDB getItem output is not null checked Invalid public method parameters Log injection Sensitive information leak Usage of multiple date time pattern formatter Zip Streaming Synchronous publication of AWS Lambda metrics XML External Entity Document Builder Factory Improper use of classes that aren't thread-safe Incorrect null check before setting a value Authorization Bypass Through User-Controlled Key Check uncaught exceptions Insufficient use of name in Amazon SQS queue Missing check on the value returned by ResultSet.next Insecure TLS version Unsanitized input is run as code Logging of sensitive information Use an enum to specify an AWS Region Improperly formatted string arguments Improper Neutralization of Input Used in a Command (Command Injection)throw inside finally Proper usage of Pattern matches.Untrusted AMI images Insecure SAML parser configuration Cross-site request forgery Case sensitive keys in S3 object user metadata Missing null check when retrieving the owner of an Amazon S3 object TLS certificate verification Stack trace not included in re-thrown exception Thread safety violation Region specification missing from AWS client initialization Insufficient number of PBEKeySpec iterations URL redirection to untrusted site Use of externally-controlled input to select classes or code Missing encryption of sensitive data in storage Ignored output of DynamoDBMapper operations Invoking String comparison method with null String Null pointer dereference Cross-site scripting Unauthenticated LDAP requests Use of inefficient APIs Low maintainability with old Android features Inefficient retrieval of first page of DynamoDB results Atomicity violation Missing handling of specifically-thrown exceptions Weak obfuscation of web request Dynamo mapper has items rule Varargs position error Clear text credentials Http handler ordering Session fixation Complicated DynamoDB query with expression attribute values Poor logging practice rule Syntax error in file Catching and not re-throwing or logging exceptions Missing check when launching an Android activity with an implicit intent Client constructor deprecation Inefficient use of stream sorting Incorrect File Permissions Arithmetic overflow or underflow Simplifiable code Loose file permissions Preferred DynamoDB GetKeys API not used Manual pagination Incorrect string equality operator Inefficient chain of AWS API calls OS command injection Internationalization Code clone SQL injection Missing check on method output Missing pagination Coral server side request forgery Untrusted data in http session Get records with limit rule Resources used by an Amazon S3 TransferManager are not released Insecure cryptography Missing timezone of SimpleDateFormat Hardcoded Active JDBC Credentials in Java Low maintainability with low class cohesion Json object refactoring rule Oversynchronization Missing release of resources rule Missing authorization Infinite loop Batch operations preferred over looping Inconsistent null check Application logging of sensitive data Object Input Stream Insecure Deserialization Weak pseudorandom number generation Insecure CORS policy Missing handling of file deletion result Amazon SQS message visibility changed without a status check State machine execution ARN is not logged Client-side KMS reencryption Unlogged exceptions in a stack trace Use Stream::anyMatch instead of Stream::findFirst or Stream::findAny Unterminated switch case blocks Batch request with unchecked failures Buffer underflow prevention

Tag: maintainability

Mandatory method not called after object creation

Mandatory methods must be called after object creation.

AWS object presence check

Manually performing an object existence check is inefficient when a built-in operation is available.

Missing timeout check on ExecutorService.awaitTermination

Missing timeout checks on awaitTermination might make the code harder to debug.

Inefficient usage of Transaction library from AWS Labs

The AWS Labs Transactions Library is a client-side solution and less efficient compared to DynamoDB native transactions.

Inefficient exception handling

Throwing too many exceptions can cause performance issues.

Use of a deprecated method

This code uses deprecated methods, which suggests that it has not been recently reviewed or maintained.

Error-prone AWS IAM policy creation

Manually creating text-based IAM policies is error-prone.

Missing statement to record cause of InvocationTargetException

Missing statements to record the underlying cause of InvocationTargetException.

Misconfigured Concurrency

Misconfigured CompletableFuture.get or Future.get.

XML Validation

Objects that parse or handle XML in XML document can lead to XML External Entity (XXE) attacks when misconfigured.

Do not catch and throw exception

Do not catch and throw the same exception.

Override of reserved variable names in a Lambda function

Overriding environment variables that are reserved by AWS Lambda might lead to unexpected behavior.

Not calling finalize causes skipped cleanup steps

Always call super.finalize explicitly.

Wrapping Caught Invocation Target Exception

Recommends type-casting the exception into unchecked exception and throwing it.

Backward compatibility breaks with error message parsing

Maintain your code's backward compatibility by checking the status code instead of parsing the error message.

Check uncaught exceptions

Check and suggest to catch all uncaught AWS API exceptions.

Use an enum to specify an AWS Region

To minimize the risk of error, use an enum instead of a string to specify an AWS Region.

Improperly formatted string arguments

Format strings appropriately for their argument types. For example, use %d, not %s, for integers.

Stack trace not included in re-thrown exception

When re-throwing an exception, make sure to include the stack trace.

Null pointer dereference

Dereferencing a null pointer can lead to unexpected null pointer exceptions.

Low maintainability with old Android features

Code uses older Android features.

Missing handling of specifically-thrown exceptions

Catching generic exceptions might hide issues when specific exceptions are thrown.

Complicated DynamoDB query with expression attribute values

Use withHashKeyValues to set one or more hash key values of a DynamoDB query

Syntax error in file

Some files contain syntax errors.

Client constructor deprecation

Client constructors are now deprecated in favor of using builders to create the client.

Simplifiable code

Simplifiable code might be harder to read or maintain.

Preferred DynamoDB GetKeys API not used

use GetKeys API of DynamodbStreamRecord directly

Code clone

Similar code fragments were detected in the same file.

Missing check on method output

Missing checks might cause silent failures that are harder to debug.

Low maintainability with low class cohesion

Classes with low class cohesion contain unrelated operations which make them difficult to understand and less likely to be used.

Json object refactoring rule

Json object refactoring rule.

Infinite loop

Use loop control flow to ensure that loops are exited, even if exceptional behaviors are encountered.

Inconsistent null check

A missing null check might cause a null dereference error.

State machine execution ARN is not logged

Log the ARN identifying the state machine execution for better debuggability.

Unlogged exceptions in a stack trace

When logging an exception, make sure to include the stack trace.

Use Stream::anyMatch instead of Stream::findFirst or Stream::findAny

Using Stream::anyMatch is more readable and convenient than using a chain of Stream::filter, Stream::findFirst or Stream::findAny and Optional::isPresent.

Unterminated switch case blocks

Terminate case statements in a switch block properly.